fix: remove pnpm from engines #1117
Merged
+1
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Belco90
approved these changes
Nov 21, 2025
Member
Belco90
left a comment
Belco90
left a comment
There was a problem hiding this comment.
@friederbluemle Good point! Thanks 🙏
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1117 +/- ##
=======================================
Coverage 96.51% 96.51%
=======================================
Files 51 51
Lines 2872 2873 +1
Branches 1179 1175 -4
=======================================
+ Hits 2772 2773 +1
Misses 100 100 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
🎉 This PR is included in version 7.13.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks
Changes
Remove
pnpmfield fromenginesin package.jsonContext
During dependency installation in my project using Yarn, I noticed the following message:
The
pnpmentry inengineswas introduced in #966, which migrated from npm to pnpm. The same PR also correctly setspackageManagertopnpm- That's the important field used when developing eslint-plugin-testing-library itself.There is no reason to require consumers of
eslint-plugin-testing-libraryto use pnpm (or any specific package manager). Therefore, the best solution is to simply remove the entry fromenginesaltogether.